Skip to content

Set minimum required Qt version to 6.9#11331

Merged
oskirby merged 18 commits into
mainfrom
bump-minimum-qt69
Jun 8, 2026
Merged

Set minimum required Qt version to 6.9#11331
oskirby merged 18 commits into
mainfrom
bump-minimum-qt69

Conversation

@oskirby

@oskirby oskirby commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Description

Now that we are deprecating the PPA, let's also start enforcing a minimum Qt version against which the app will build.

This is mostly a straightforward removal of backwards compatibility hacks - except for the fact that the newest Github runner images are on Ubuntu Noble, and therefore only provide Qt 6.4.2. Thus we encountered a bunch of pain by switching our Linux tests over to the static Qt builds from Taskcluster.

Reference

i.e Jira or Github issue URL

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@oskirby oskirby force-pushed the bump-minimum-qt69 branch from 8808bd3 to 7f31c1c Compare June 2, 2026 17:34
@oskirby oskirby force-pushed the bump-minimum-qt69 branch from 7f31c1c to 7a382c8 Compare June 2, 2026 19:54
@oskirby oskirby force-pushed the bump-minimum-qt69 branch 3 times, most recently from a1c2f06 to f5adaef Compare June 2, 2026 21:15
@oskirby oskirby force-pushed the bump-minimum-qt69 branch from f5adaef to 74f5e85 Compare June 2, 2026 21:20
@oskirby oskirby force-pushed the bump-minimum-qt69 branch from 74e9efb to 68f4e17 Compare June 3, 2026 00:18
@oskirby oskirby force-pushed the bump-minimum-qt69 branch from 53e2099 to 967f404 Compare June 3, 2026 15:07
@oskirby oskirby force-pushed the bump-minimum-qt69 branch 4 times, most recently from c227cf1 to 58e49bf Compare June 3, 2026 20:05
@oskirby oskirby force-pushed the bump-minimum-qt69 branch from 58e49bf to ec5357e Compare June 3, 2026 20:29
@oskirby oskirby marked this pull request as ready for review June 3, 2026 21:29
@oskirby oskirby requested review from ahal and removed request for a team June 3, 2026 21:29
@oskirby oskirby changed the title WIP: Set minimum required Qt version to 6.9 Set minimum required Qt version to 6.9 Jun 3, 2026
@oskirby oskirby force-pushed the bump-minimum-qt69 branch from 6bc4826 to c3d014b Compare June 3, 2026 22:31
@oskirby oskirby force-pushed the bump-minimum-qt69 branch from c3d014b to 6819283 Compare June 3, 2026 22:36

@mcleinman mcleinman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but would love another review on this as well before merging. Thanks!

Comment thread src/CMakeLists.txt
Comment thread src/cmake/linux.cmake
Comment thread src/cmake/android.cmake

@strseb strseb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@oskirby oskirby merged commit cff0056 into main Jun 8, 2026
144 of 145 checks passed
@oskirby oskirby deleted the bump-minimum-qt69 branch June 8, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants